fix(authz): 禁止教师通过新建课程自授任课关系

This commit is contained in:
LoveChengke committed 2026-11-07 02:02:01 +08:00
1 parent 71cc8eb605
commit e49dd0bc39
8 files changed
+36 -14

No files matched your search

+2 -2
View File
@@ -325,7 +325,7 @@ async function removeStudent(row: StudentDto): Promise<void> {
const courseForm = reactive({ name: '' });
async function addCourse(): Promise<void> {
if (!canManageDetailCourses.value) return;
if (!auth.isAdmin || !canManageDetailCourses.value) return;
if (!detail.value || !courseForm.name.trim()) {
ElMessage.warning('请输入课程名称');
return;
@@ -771,7 +771,7 @@ async function saveSettings() {
</el-table-column>
</el-table>
<el-input
v-if="canManageDetailCourses"
v-if="auth.isAdmin && canManageDetailCourses"
v-model="courseForm.name"
placeholder="输入课程名称后回车快速添加"
class="mt-12"
+2 -1
View File
@@ -187,6 +187,7 @@ async function onClassChange(): Promise<void> {
const SUBJECT_PREFIX = 'subject:';
const subjectOptions = computed(() => {
if (!auth.isAdmin) return [];
const existing = new Set(courses.value.map((item) => item.name));
return SUBJECT_CATALOG.filter((name) => !existing.has(name));
});
@@ -221,7 +222,7 @@ const ownCourses = computed(() =>
);
/** 能不能在该班新建科目(与课表管理同权限:管理员或本班班主任) */
const canCreateCourse = computed(() => auth.canManageClass('schedule:write', filter.classId));
const canCreateCourse = computed(() => auth.isAdmin);
/** 录入弹窗的默认科目:优先沿用页面筛选,但筛的是别人的科目时退回"我的科目"第一条 */
function defaultFormCourseId(): string {
@@ -222,6 +222,7 @@ const formCoursesLoading = ref(false);
/** 该班还没有的科目(来自 shared 的 SUBJECT_CATALOG) */
const newSubjectOptions = computed(() => {
if (!auth.isAdmin) return [];
const existing = new Set(formCourses.value.map((item) => item.name));
return SUBJECT_CATALOG.filter((name) => !existing.has(name));
});
@@ -237,8 +238,8 @@ const ownFormCourses = computed(() =>
auth.isAdmin ? formCourses.value : formCourses.value.filter((item) => item.teacherId === auth.user?.id),
);
/** 该班里能不能新建科目:与课表管理同权限(管理员或本班班主任) */
const canCreateCourse = computed(() => auth.canManageClass('schedule:write', form.classId));
/** 新建科目会建立任课关系,仅管理员可操作。 */
const canCreateCourse = computed(() => auth.isAdmin);
async function loadFormCourses(): Promise<void> {
const classId = form.classId;
@@ -325,10 +326,10 @@ async function resolveCourseId(): Promise<string | null> {
await loadFormCourses();
return reusedId;
}
// 新建课程需要"管理员或本班班主任"权限(与课表管理一致),科任老师会被 403 拦截
// 新建课程会建立任课关系,统一交给管理员配置。
ElMessage.error(
`新建科目「${name}」失败:${
error instanceof Error ? error.message : '仅班主任/管理员可以在班级下新建课程'
error instanceof Error ? error.message : '请联系管理员建立科目及任课关系'
},可改用已有课程或直接留空发布`,
);
throw error;
@@ -622,7 +623,7 @@ function canEditContent(row: HomeworkDto): boolean {
? '正在加载该班课程…'
: canCreateCourse
? '只列你任教的科目;该班还没有的科目在「其他科目(新建)」里,选中后自动建课再发布'
: '只列你任教的科目;需要别的科目请先由班主任/管理员在课表管理里建好并分配任课老师'
: '只列你任教的科目;需要别的科目请联系管理员建立科目并分配任课老师'
}}
</div>
</el-form-item>
@@ -504,10 +504,10 @@ watch(tab, () => {
selectedLayout.value = plan.value.timeLayoutId;
});
const missingSubjects = computed(() =>
SUBJECT_CATALOG.filter((name) => !courses.value.some((c) => c.name === name)),
auth.isAdmin ? SUBJECT_CATALOG.filter((name) => !courses.value.some((c) => c.name === name)) : [],
);
async function addSubject(name: string) {
if (!canWrite.value) return;
if (!canWrite.value || !auth.isAdmin) return;
try {
const created = await courseApi.create({ classId: classId.value, name });
courses.value.push(created);
@@ -107,6 +107,7 @@ async function loadCourses(): Promise<void> {
const SUBJECT_PREFIX = 'subject:';
const subjectOptions = computed(() => {
if (!auth.isAdmin) return [];
const existing = new Set(courses.value.map((item) => item.name));
return SUBJECT_CATALOG.filter((name) => !existing.has(name));
});